Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Nitpick Changes #2683

Open
wants to merge 7 commits into
base: 1.20.1
Choose a base branch
from
Open

Various Nitpick Changes #2683

wants to merge 7 commits into from

Conversation

YoungOnionMC
Copy link
Member

What

Fixes #309

Implementation Details

adding tags, removing tags, adding recipes etc

Outcome

1 less old pr

@YoungOnionMC YoungOnionMC requested a review from a team as a code owner December 31, 2024 07:11
Copy link
Contributor

@Spicierspace153 Spicierspace153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good from a code perspective but ghost should check the recipes for balance

@YoungOnionMC YoungOnionMC added the type: bugfix general bug fixes label Dec 31, 2024
@@ -53,6 +53,7 @@ private static void initCasingLang(RegistrateLangProvider provider) {
replace(provider, "block.gtceu.stainless_steel_gearbox", "Stainless Steel Gearbox Casing");
replace(provider, "block.gtceu.titanium_gearbox", "Titanium Gearbox Casing");
replace(provider, "block.gtceu.tungstensteel_gearbox", "Tungstensteel Gearbox Casing");
replace(provider, "block.gtceu.steel_turbine_casing", "Magnalium Turbine Casing");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, not doing this

…ll blocks that need the config to work. Then, in MixinHelpers, add *those tags* to the MINEABLE_WITH_PICKAXE tag instead of the blocks themselves.
…the one from the GTFluid (if the provided fluid is one, otherwise fall back to the key's default state.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bugfix general bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistancy and Greg Tweaks
3 participants