-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Nitpick Changes #2683
Open
YoungOnionMC
wants to merge
7
commits into
1.20.1
Choose a base branch
from
yo/anne-fixes
base: 1.20.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Various Nitpick Changes #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spicierspace153
approved these changes
Dec 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good from a code perspective but ghost should check the recipes for balance
screret
requested changes
Dec 31, 2024
@@ -53,6 +53,7 @@ private static void initCasingLang(RegistrateLangProvider provider) { | |||
replace(provider, "block.gtceu.stainless_steel_gearbox", "Stainless Steel Gearbox Casing"); | |||
replace(provider, "block.gtceu.titanium_gearbox", "Titanium Gearbox Casing"); | |||
replace(provider, "block.gtceu.tungstensteel_gearbox", "Tungstensteel Gearbox Casing"); | |||
replace(provider, "block.gtceu.steel_turbine_casing", "Magnalium Turbine Casing"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, not doing this
src/main/java/com/gregtechceu/gtceu/data/recipe/misc/MachineRecipeLoader.java
Show resolved
Hide resolved
…use, as it turns out, that broke stuff.
…ll blocks that need the config to work. Then, in MixinHelpers, add *those tags* to the MINEABLE_WITH_PICKAXE tag instead of the blocks themselves.
…the one from the GTFluid (if the provided fluid is one, otherwise fall back to the key's default state.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #309
Implementation Details
adding tags, removing tags, adding recipes etc
Outcome
1 less old pr