Port passthrough hatches to MUI2 and allow them to be togged #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, would it make sense to have the input and output be toggled separately, or just both at the same time (how I have it now)? |
Zorbatron
changed the title
ghzdude
reviewed
Oct 29, 2024
...egtech/common/metatileentities/multi/multiblockpart/MetaTileEntityPassthroughHatchFluid.java
Outdated
Show resolved
Hide resolved
...regtech/common/metatileentities/multi/multiblockpart/MetaTileEntityPassthroughHatchItem.java
Outdated
Show resolved
Hide resolved
...egtech/common/metatileentities/multi/multiblockpart/MetaTileEntityPassthroughHatchFluid.java
Outdated
Show resolved
Hide resolved
ALongStringOfNumbers
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Should be merged after #2622 to prevent any conflicts with that PR.
Zorbatron
force-pushed
the
zb-toggle-passthrough
branch
from
1114400 to
38394fe
Compare
ghzdude
approved these changes
Jan 21, 2025
...egtech/common/metatileentities/multi/multiblockpart/MetaTileEntityPassthroughHatchFluid.java
Outdated
Show resolved
Hide resolved
ALongStringOfNumbers
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To resolve #2490
Implementation Details
I migrated them to MUI2 and added logic in
update()to only move stuff when active.Outcome
Passthrough hatches can be toggled in their GUIs and controller covers can be attached.
Potential Compatibility Issues
Passthrough hatches which were placed before this change should be set to working when loaded for the first time because of a check in
readFromNBT.I'm not satisfied with the outcome of the fluid passthrough hatch's new UI, so I'll have to keep working on that. *Please don't merge until the FluitSlot from MUI2 matches how it works in MUIno idea when this will be changed so oh well.