Implement Bucket Behavior to Cells #2660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move methods to IItemBehaviour
|
|
||
| blockHandler = createHandler(cellFluid, world, pos.offset(facing)); | ||
| success = GTTransferUtils.transferFluids(cellHandler, blockHandler) > 0; | ||
| isFill = true; |
There was a problem hiding this comment.
Are these isFill backwards? Right now you are setting isFill to true when you are attempting to transfer fluid from the cell into the world, which is emptying, not filling.
There was a problem hiding this comment.
i interpreted it as "filling the block", but it really could be either or.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
allows GT cells to pick up and place in world fluids
Implementation Details
add behavior to
ItemFluidContainerOutcome
"Finally, a weapon to surpass Thermal Expansion Reservoirs"