-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Flexibile Loads #628
WIP: Flexibile Loads #628
Conversation
Most tests passing now, remaining error (in ci/circleci:test) appears to be from CI itself:
Appreciate any review / feedback to solve this @BDonnot |
Hello, Sorry for the delay. This is so weird. I'll check the CI ASAP |
Hello, I think the CI is working on the dev_1.10.4 now, can you synch and see if it solves your issue ? |
Afraid I am still getting the same error as above for the CI. @BDonnot |
"1. **End of Chronics**: The agent reaches the end of the chronics (timeseries) for an Episode (no more data => scenario ends)\n", | ||
"2. **Disconnected Generator / Load**: A load, generator is disconnected from the grid. This also applies to Energy Storage Systems (ESSs) if they are being controlled (agent told it to charge / discharge some energy)\n", | ||
"3. **Islanding**: The grid splits into multiple parts / islands. For example, a load of generator is alone on a busbar. \n", | ||
"4. **Powerflow Divergence**: The redispatching routine \"diverges\": this means that Grid2OP is not able to find a setpoint for the generators for which both \"pmin, pmax and the ramps constrained\" as well as the \"load / generator balancing the solver \"diverges\" and is not able to compute the next state (often meaning there are no feasible solutions to the Kirchoff's laws)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to update the doc but actually point 4 above is two different things:
- either the backend diverge (cannot compute the flows, no feasible solution found)
- or the "grid2op routine" to compute the "redispatching" fails
It is two distinct things.
|
||
import sys | ||
from pathlib import Path | ||
sys.path.append(str(Path(__file__).parent)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid doing that if possible
|
||
import sys | ||
from pathlib import Path | ||
sys.path.append(str(Path(__file__).parent)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was not necessary before, and tests used to pass on the CI, maybe this is what caused the issue. Can you remove all these changes in the test suite and run it again ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying that now, was a hotfix to get the tests running locally but seems I forgot to remove it later
Hi, I see you added import sys
from pathlib import Path
sys.path.append(str(Path(__file__).parent)) In a lot of files. That should not be necessary (did not used to be there when tests passed). Have you tried to remove it and see if tests pass ? Maybe you are missing the gym / gymnasium import when you do that (it's in general not a good idea to "mess with" python sys.path, it often leads to weird behaviour). Maybe it's not the cause of the problem, but maybe it is :-) |
Also (to keep track of it, I noticed it and did not want to "discover this again later") I think you did not update the https://grid2op.readthedocs.io/en/latest/modeled_elements.html page of the doc nor the https://grid2op.readthedocs.io/en/latest/mdp.html, for example https://grid2op.readthedocs.io/en/latest/mdp.html#action-space or https://grid2op.readthedocs.io/en/latest/mdp.html#state-space |
Hello, I fixed the issues caused by the install of gymnasium 1.0 in dev_1.10.4, I think once you'll have synched this will no longer be an issue :-) Benjamin |
|
Closing due to migration to dev_1.11.0. |
Attempt to extend Redispatching by enabling Environment's to have flexible loads. See "getting_started" / "12_Flexibility.ipynb" for example use. Related to issue #623 (will move onto load / generator shedding once this works).
Currently working:
Conventions:
Positive flexibility: Reduce consumption (less demand in the grid)
Negative flexibility: Increase consumption (more demand in the grid)
target_flex: Sum of all flexibility at a load
actual_flex: Sum of all physically feasible flexibility at a load (determined by Environment)