Skip to content

Commit

Permalink
use Span api instead (#114)
Browse files Browse the repository at this point in the history
  • Loading branch information
cleidiano committed Aug 15, 2023
1 parent 1dd3c68 commit a612c79
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class OpenTelemetryTracer : TracerEngine, ThreadContextManager<Span> {
}

override fun setOperationName(name: String) {
val span = getRootSpan()
val span = currentSpan()
span?.updateName(name)
}

Expand All @@ -37,23 +37,23 @@ class OpenTelemetryTracer : TracerEngine, ThreadContextManager<Span> {
}

override fun addRootProperty(key: String, value: String?) {
getRootSpan()?.addProperty(key, value)
currentSpan()?.addProperty(key, value)
}

override fun addProperty(key: String, value: Number?) {
Span.current()?.addProperty(key, value)
}

override fun addRootProperty(key: String, value: Number?) {
getRootSpan()?.addProperty(key, value)
currentSpan()?.addProperty(key, value)
}

override fun addProperty(key: String, value: Boolean?) {
Span.current()?.addProperty(key, value)
}

override fun addRootProperty(key: String, value: Boolean?) {
getRootSpan()?.addProperty(key, value)
currentSpan()?.addProperty(key, value)
}

override fun addProperty(key: String, value: List<*>) {
Expand Down Expand Up @@ -90,7 +90,7 @@ class OpenTelemetryTracer : TracerEngine, ThreadContextManager<Span> {
}

override fun notifyRootError(exception: Throwable, expected: Boolean) {
getRootSpan()?.let { span ->
currentSpan()?.let { span ->
OpenTelemetryUtils.notifyError(span, exception, expected)
}
}
Expand All @@ -102,7 +102,7 @@ class OpenTelemetryTracer : TracerEngine, ThreadContextManager<Span> {
}

override fun notifyRootError(message: String, params: Map<String, String?>, expected: Boolean) {
getRootSpan()?.let { span ->
currentSpan()?.let { span ->
OpenTelemetryUtils.notifyError(span, message, params, expected)
}
}
Expand Down Expand Up @@ -146,7 +146,7 @@ class OpenTelemetryTracer : TracerEngine, ThreadContextManager<Span> {
} as AttributeKey<T>
}

private fun getRootSpan(): Span? = Context.root().get(SpanContextKey.KEY)
private fun currentSpan(): Span? = Span.current()

companion object {
const val TRACER_NAME = "events-tracing"
Expand Down

This file was deleted.

0 comments on commit a612c79

Please sign in to comment.