ASPL-587 #161
Merged
ASPL-587 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmurp
reviewed
Jun 13, 2024
| if(m_status == null) {// In case of internet disconnect Status is set to null. | ||
| m_status = FAILED; | ||
| } | ||
| if (m_status.equalsIgnoreCase("Ready")) { |
There was a problem hiding this comment.
These changes now have 2 "if" cases for handling the "Ready" state. The new conditional if (m_status.equalsIgnoreCase("Ready")) { as well as the existing conditional if(m_status != null && m_status.equalsIgnoreCase("Ready")) {.
Also, each of the status checks does an "if" check, as opposed to an "else if" or a switch statement. We should clean that up.
Finally, the indentation in this area makes the code very difficult to follow. Can you fix that?
There was a problem hiding this comment.
Sure, Matt. Cleaned the code & fixed the indentation too.
mattmurp
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira02.hclpnp.com/browse/ASPL-587