Install the FastJet addons headers to work around #227 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Thomas, I think we might revert the addon_build functionality due to lack of maintainers, but I'll merge to fix the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably not the most elegant, but a viable fix for #227. @forthommel I didn't spend enough time diving into the
fccanalyses_addon_buildfunction to figure out whether there is a way to make that do the installation instead. If there is one, we could obviously also do that.Additionally, it seems this is only necessary for the
FastJetaddon, but not for theONNXRuntimeone. This means that is also possible that these headers just leak accidentally, in this case, this PR is really just a quick fix rather than a proper one.In any case #227 currently breaks all stacks with a recent build of FCCAnalyses, because root errors out when it loads the dictionary.