Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen transforms #744

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Eigen transforms #744

wants to merge 20 commits into from

Conversation

ZackAttack614
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.63%. Comparing base (c1fbb97) to head (f3297f0).
Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
- Coverage   39.70%   39.63%   -0.07%     
==========================================
  Files         135      140       +5     
  Lines       22392    22697     +305     
==========================================
+ Hits         8890     8997     +107     
- Misses      13502    13700     +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZackAttack614 ZackAttack614 requested a review from psavery January 10, 2025 19:12
Copy link
Collaborator

@kpwelsh kpwelsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor things should be changed.
A couple of minor things could be changed.

Not 100% sure if there is a better way to do the xsimd or not.

tests/transforms/test_gvec_to_xy_from_file.py Outdated Show resolved Hide resolved
hexrd/transforms/cpp_sublibrary/src/transforms.cpp Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
tests/transforms/test_make_binary_rmat.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@psavery
Copy link
Collaborator

psavery commented Jan 14, 2025

I ran a quick performance check on running hexrd fit-grains ./mruby_config_composite.yml, and after these changes, it took 139 seconds instead of 141.5 seconds before. It's about the same speed - which is good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants