Update maintenance to support passing job timeout #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettEHill
requested review from
thewatermethod,
fbonds,
nvms,
hardwarehuman,
kryswisnaskas and
AdamAdHocTeam
| type, | ||
| id, | ||
| }, | ||
| requiredLaunchScript, | ||
| requiresLock, | ||
| holdLock, | ||
| ); | ||
| jobSettings: timeout !== undefined ? { timeout } : {}, |
There was a problem hiding this comment.
couldnt this just be timeout instead of timeout !== undefined?
AdamAdHocTeam
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
How to test
jest test leverage the new functionality, but there is not a good way to test the timeout outside of production due to the latency be controlled by actually taking a long time to download.
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy