Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #3434] React USWDS, React, Next.JS upgrade #3515

Merged
merged 25 commits into from
Jan 28, 2025
Merged

[Issue #3434] React USWDS, React, Next.JS upgrade #3515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
a237107
Initial upgrade
acouch Jan 14, 2025
204d271
Upgrade testing-lib and temp remove storybook design
acouch Jan 14, 2025
d85290b
Update sessions.ts for dynamic apis
acouch Jan 14, 2025
9d35919
Update pages for next-intl and dynamic param changes
acouch Jan 14, 2025
b588b6e
Update next.config.js for removing exp
acouch Jan 15, 2025
27faff5
Update for async params
acouch Jan 15, 2025
3ec1806
Update for async params
acouch Jan 15, 2025
470ce26
Update for async comp and tests
acouch Jan 15, 2025
a560166
Update for format
acouch Jan 15, 2025
7b498e1
Update sharp version
acouch Jan 15, 2025
074896f
Update page tests
acouch Jan 17, 2025
89ea552
Update for format
acouch Jan 17, 2025
f856969
Update featureflag test, add user page test
acouch Jan 17, 2025
f74e6d3
Update ci-frontend-e2e.yml to skip attachment loading
acouch Jan 17, 2025
278d8d5
Update local.env to skip attachment loading
acouch Jan 17, 2025
053efbe
Update ci-frontend-e2e.yml to skip attachment loading
acouch Jan 17, 2025
2d268d4
Update local.env to renable attachment loading
acouch Jan 17, 2025
11f11b9
Downgrade to sass 1.77.0 to suppress warnings
acouch Jan 22, 2025
c9bd320
Update Header.tsx and compilation options
acouch Jan 22, 2025
75afac5
Update package.json
acouch Jan 23, 2025
f9d6e51
Update playwright.config.ts
acouch Jan 23, 2025
59502ca
Remove sync test funcs for async
acouch Jan 24, 2025
c802a92
Skips flaky test
acouch Jan 24, 2025
2574e3e
Update param names
acouch Jan 27, 2025
f5fe517
Readd test
acouch Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci-frontend-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ jobs:
- name: Start API Server for e2e tests
run: |
cd ../api
echo "ENABLE_OPPORTUNITY_ATTACHMENT_PIPELINE=false" >> override.env
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially added for a fix, but leaving as we don't need attachments.

make init db-seed-local populate-search-opportunities start &
cd ../frontend
# Ensure the API wait script is executable
Expand Down
6 changes: 1 addition & 5 deletions frontend/.storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,7 @@ function blockSearchEnginesInHead(head) {
*/
const config = {
stories: ["../stories/**/*.@(mdx|stories.@(js|jsx|ts|tsx))"],
addons: [
"@storybook/addon-essentials",
"@storybook/addon-designs",
"@chromatic-com/storybook",
],
addons: ["@storybook/addon-essentials", "@chromatic-com/storybook"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temp remove @storybook/addon-designs until it is React 19 compatible

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good - are we actively using this in any case, or can we just remove it for good? Since there's not even an issue to add React 19 support I wouldn't be too confident that it'll come any time soon

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice it is "removed for good" as it is removed from npm and there is no config left.


framework: {
name: "@storybook/nextjs",
Expand Down
2 changes: 1 addition & 1 deletion frontend/next-env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
/// <reference types="next/image-types/global" />

// NOTE: This file should not be edited
// see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information.
// see https://nextjs.org/docs/app/api-reference/config/typescript for more information.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was autogen

4 changes: 1 addition & 3 deletions frontend/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,7 @@ const nextConfig = {
// https://nextjs.org/docs/app/api-reference/next-config-js/output
output: "standalone",
sassOptions: appSassOptions,
experimental: {
serverComponentsExternalPackages: ["newrelic"],
},
serverExternalPackages: ["newrelic"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer experimental!

webpack: (config) => {
nrExternals(config);
return config;
Expand Down
Loading