Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 3498] exclude attachments from search response #3531

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

babebe
Copy link
Collaborator

@babebe babebe commented Jan 15, 2025

Summary

Fixes #{3498}

Time to review: 5 mins

Changes proposed

Modified the search method of our opensearch client to pass through an optional excludes param
Modified our search API to set the attachments field to be excluded

chouinar
chouinar previously approved these changes Jan 15, 2025
Copy link
Collaborator

@chouinar chouinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@babebe babebe requested a review from chouinar January 16, 2025 14:21
@babebe babebe merged commit c9c2e5c into main Jan 16, 2025
@babebe babebe deleted the 3498/exclude_attachments_from_search_response branch January 16, 2025 14:54
@babebe babebe linked an issue Jan 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the search response to exclude the attachments from the response
3 participants