[Issue #3628] allow error page to be interactive without refresh #3629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-s-nava
requested review from
acouch,
andycochran and
btabaska
as code owners
doug-s-nava
force-pushed
the
dschrashun/reset-search-error-boundary
branch
from
0f1da69 to
57770f6
Compare
doug-s-nava
force-pushed
the
dschrashun/reset-search-error-boundary
branch
from
7e68146 to
e32fb7a
Compare
acouch
reviewed
Jan 28, 2025
|
|
||
| useEffect(() => { | ||
| console.error(error); | ||
| }, [error]); |
There was a problem hiding this comment.
Could we use or extend one of the errors from https://github.com/HHS/simpler-grants-gov/blob/main/frontend/src/errors.ts so we have more consistent error formatting and handling?
There was a problem hiding this comment.
We could punt to this #3651 if that is what yr thinking
There was a problem hiding this comment.
the errors caught here largely will be based on the definitions in our errors file, so not sure what to do here
There was a problem hiding this comment.
I would think we would wrap the output. I guess I don't see how this error is formed or called.
acouch
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3628
Time to review: 10 mins
Changes proposed
Fixes bug where search error page had an unusable UI
Also introduces a usePrevious hook as pulled from https://www.developerway.com/posts/implementing-advanced-use-previous-hook (I think this hook implementation used to be in the React docs themselves, but I don't see it there anymore)
Context for reviewers
This was fixed by correctly using NextJs's
resetmethod which is not well documented https://nextjs.org/docs/app/api-reference/file-conventions/error#resetBecause NextJS's error handling uses React error boundaries under the hood, which are basically designed to set an error state and take action based on that state, it makes sense that something explicit must be done to tell the error boundary that the app is no longer in an error state. That's what reset is for, so by calling reset whenever a user interaction occurs on the error page, the problem disappears.
Test steps
npm run devAdditional information