[Unticketed] Modify agency transform to ignore a new field #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidDudas-Intuitial
pushed a commit
that referenced
this pull request
Feb 7, 2025
## Summary ### Time to review: __2 mins__ ## Changes proposed Adds a filter to the transform agency task to skip a new field ## Context for reviewers grants.gov added a new type of field to the TGroups table (the key-value table that stores agency info) which is causing the following error: `Unknown tgroups agency field AllowSubmitWithExpSAM`. While I'm not sure what this field does exactly (something to do with allowing users to submit even if their SAM validation isn't done), I know we don't need to worry about it for a while as we don't yet handle anything with apply. So for now, ignoring the field so we stop erroring on these fields. We can always pick it back up later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Time to review: 2 mins
Changes proposed
Adds a filter to the transform agency task to skip a new field
Context for reviewers
grants.gov added a new type of field to the TGroups table (the key-value table that stores agency info) which is causing the following error:
Unknown tgroups agency field AllowSubmitWithExpSAM.While I'm not sure what this field does exactly (something to do with allowing users to submit even if their SAM validation isn't done), I know we don't need to worry about it for a while as we don't yet handle anything with apply. So for now, ignoring the field so we stop erroring on these fields. We can always pick it back up later.