Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHIR-49113 Biologically Derived Product Module #3273

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ssi-db
Copy link
Contributor

@ssi-db ssi-db commented Jan 21, 2025

HL7 FHIR Pull Request

Note: No pull requests will be accepted against ./source unless logged in the HL7 Jira issue tracker.

If you made changes to any files within ./source please indicate the Jira tracker number this pull request is associated with: FHIR-49113

Description

https://jira.hl7.org/browse/FHIR-49113

Creating module page for BDP and related resources based on content outlined in Confluence: https://confluence.hl7.org/display/OO/Module%3A+Biologically+Derived+Product

@ssi-db
Copy link
Contributor Author

ssi-db commented Jan 21, 2025

@costateixeira Can you give this a quick skim? Everything looks to be working but it's kind of a guess-and-test process.

Note I haven't actually moved any resources to be under the module, that would be something separate, but I had to register the module to get numbered anchor elements.

@ssi-db ssi-db marked this pull request as ready for review January 21, 2025 01:40
@ssi-db ssi-db requested a review from costateixeira January 21, 2025 02:31
Copy link
Contributor

@lmckenzi lmckenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there approval from FMG to define a new "Biologically Derived Product" module? Module existence is strictly controlled because all modules need to be listed on the home page and there's limited screen real-estate. Please raise this with the fmg ([email protected]) and get approval first. There will also need to be a change to add this module to the home page and other places where the modules get listed if approved.

@ssi-db
Copy link
Contributor Author

ssi-db commented Jan 22, 2025

Yes there was approval at September WGM

@lmckenzi
Copy link
Contributor

@grahamegrieve do you want this merged prior to or alongside the changes to introduce the module onto the home page?

@martitajames
Copy link
Contributor

@lmckenzi and @grahamegrieve -- We we have been drafting module content for over a year for all of the healthcare product domains. We discussed this at the last couple of WGM with FHIR-I. We agreed to push content into the CI Build before @grahamegrieve decides how this should be integrated into the current modules. Grahame also said if we get push back on doing this to raise the issue -- so @grahamegrieve can we please get this moved to the CI as we agreed? If not, please let me know.

@lmckenzi
Copy link
Contributor

Integrated into the current modules is not the same as defining a new module page. Did FMG approve a new "module", or just the resources?

@ssi-db ssi-db requested a review from grahamegrieve January 28, 2025 21:42
@ssi-db
Copy link
Contributor Author

ssi-db commented Feb 6, 2025

Requesting O&O co-chairs to weigh in on this based on conversations held at January WGM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants