Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads files redirected #136

Merged
merged 13 commits into from
Jul 22, 2024
Merged

Ads files redirected #136

merged 13 commits into from
Jul 22, 2024

Conversation

max-ostapenko
Copy link
Contributor

@max-ostapenko max-ostapenko commented Jul 7, 2024

Sometimes sellers.json redirects to the main adtech domain (for some business groups or managed domains), and the original page would be listed as a seller/publisher page on the file. Need to use the domain from redirect URL, instead of page.

  • tracking redirect final url

Plus several updates to the test action:

  • forcing WPT requests to use POST method to send all the custom metrics code (fixes 'Too long URL' error),
  • in some cases the length of a PR comment content is too long (65K chars limit), so saving .md file as artifact instead,
  • moved most of the code out of yaml to simplify the workflow update process

As the changes are not yet applied in test check - it fails. See https://github.com/max-ostapenko/custom-metrics/pull/1 instead.


Test websites:

tests/wpt.js Outdated
* @returns {string[]} Test websites
*/
getTestWebsites() {
const urlPattern = /((http|https):\/\/[a-zA-Z0-9.-]+(\.[a-zA-Z]{2,4})(\/[a-zA-Z0-9_.-]+)*(\/?)(\?[a-zA-Z0-9_.-]+=[a-zA-Z0-9%_.-]+)*(\#?)([a-zA-Z0-9%_.-=]+)*)/;

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that overlaps with 0-9 in the same character class, and is equivalent to \[.\/0-9:;<=\].
@max-ostapenko max-ostapenko requested a review from tunetheweb July 8, 2024 22:26
@max-ostapenko max-ostapenko marked this pull request as ready for review July 8, 2024 22:26
@max-ostapenko
Copy link
Contributor Author

@tunetheweb just want to clarify that regardless of failing checks, it's ready for review and hopefully merge.

@rviscomi rviscomi merged commit fc4134f into HTTPArchive:main Jul 22, 2024
1 of 2 checks passed
@max-ostapenko max-ostapenko deleted the yammering-meerkat branch July 22, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants