-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ads files redirected #136
Merged
Merged
Ads files redirected #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/wpt.js
Outdated
* @returns {string[]} Test websites | ||
*/ | ||
getTestWebsites() { | ||
const urlPattern = /((http|https):\/\/[a-zA-Z0-9.-]+(\.[a-zA-Z]{2,4})(\/[a-zA-Z0-9_.-]+)*(\/?)(\?[a-zA-Z0-9_.-]+=[a-zA-Z0-9%_.-]+)*(\#?)([a-zA-Z0-9%_.-=]+)*)/; |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range
Suspicious character range that overlaps with 0-9 in the same character class, and is equivalent to \[.\/0-9:;<=\].
@tunetheweb just want to clarify that regardless of failing checks, it's ready for review and hopefully merge. |
rviscomi
approved these changes
Jul 22, 2024
rviscomi
reviewed
Jul 23, 2024
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes
sellers.json
redirects to the main adtech domain (for some business groups or managed domains), and the original page would be listed as a seller/publisher page on the file. Need to use the domain from redirect URL, instead ofpage
.Plus several updates to the test action:
As the changes are not yet applied in test check - it fails. See https://github.com/max-ostapenko/custom-metrics/pull/1 instead.
Test websites: