Adding degree and first_timer stats #303
Conversation
Add files via upload
Add files via upload
Add files via upload
Add files via upload
stats/views.py
Outdated
| degree_count_confirmed = Application.objects.filter(status=APP_CONFIRMED).values('degree') \ | ||
| .annotate(applications=Count('degree')) \ | ||
| .order_by('-applications')[:10] | ||
|
|
There was a problem hiding this comment.
This is starting to have too many queries that look like the same. Any chance we can factor all those into a single query? I'm afraid on performance here and pushing too hard on the DB.
There was a problem hiding this comment.
Query sets are lazy, ones you call them they call the DB. If we put it in one "query" it really doesn't matter, django will call them one by one. Or at least it's what I understant from the documentation.
There was a problem hiding this comment.
Yes, but you have several query sets here, which translates to several DB queries on the background. Making one query that returns degrees/university/food... and then processing the dictionary to generate the aggregations may actually perform better as it runs in a single query and reduces the amount of times it requires to connect to the DB.
| type: 'category' | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
Same for the UI? Maybe it's time to create a new tab? It may become unreadable.
raquelpanapalen
changed the title
Optimization started
Bar char fix
Add files via upload
Add files via upload
lennyface & resume
lennyface & resume
Add files via upload
defaultdict(int)
What this PR does / Why we need it
Adding degree stats (only shown the top 10)
Adding first_timer stats
Adding lennyface stats (top 5)
Adding resume stats
Optimization
Defaultdict(int)
Which issue(s) this PR fixes (optional)
References #103
Special notes for your reviewer (optional)
Some questions
Additional Notes (optional)
Do you want to add anything else? We ❤️ to hear your opinions!