Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch email and phone number on authentication #8

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

silicoflare
Copy link
Member

Along with the usual details being fetched, the API now fetches and returns the email address and phone number of the student. This feature will be useful in the apps we plan to build in the future.

@silicoflare
Copy link
Member Author

@aditeyabaral @Icarus131 please lmk if there are any changes, thanks!

@aditeyabaral
Copy link
Member

@silicoflare
Just a comment: Ideally, this API is meant for authentication only, with minimum details returned from it to render placeholders like name, branch, etc. This is just an authentication gateway (to keep things quick), not a way to extract details.

If you are looking to develop apps with the backend APIs where there is a focus on reading details from the website, I would suggest contributing to this: https://github.com/aditeyabaral/pesu-academy-api

.gitignore Outdated Show resolved Hide resolved
app/pesu.py Outdated Show resolved Hide resolved
@aditeyabaral
Copy link
Member

You also need to update the README with the new data you are returning.

@silicoflare
Copy link
Member Author

@silicoflare
Just a comment: Ideally, this API is meant for authentication only, with minimum details returned from it to render placeholders like name, branch, etc. This is just an authentication gateway (to keep things quick), not a way to extract details.

If you are looking to develop apps with the backend APIs where there is a focus on reading details from the website, I would suggest contributing to this: https://github.com/aditeyabaral/pesu-academy-api

So here's the thing: in pesu-tix, when the user signs in using PESU Auth, I want to fetch all these details and store it in a database, so that when the student registers for the event, all those details will be added to the event database record, which cuts the need of the user to fill any additional forms.

@silicoflare
Copy link
Member Author

You also need to update the README with the new data you are returning.

Yes will do, thanks!

@aditeyabaral
Copy link
Member

@silicoflare
Just a comment: Ideally, this API is meant for authentication only, with minimum details returned from it to render placeholders like name, branch, etc. This is just an authentication gateway (to keep things quick), not a way to extract details.
If you are looking to develop apps with the backend APIs where there is a focus on reading details from the website, I would suggest contributing to this: https://github.com/aditeyabaral/pesu-academy-api

So here's the thing: in pesu-tix, when the user signs in using PESU Auth, I want to fetch all these details and store it in a database, so that when the student registers for the event, all those details will be added to the event database record, which cuts the need of the user to fill any additional forms.

Alright, but no more fields will be added (note to future PR raisers). Please address the requested changes and push a commit.

@silicoflare
Copy link
Member Author

@aditeyabaral i've made the requested changes, please do check!

@silicoflare silicoflare marked this pull request as draft April 16, 2024 16:39
@silicoflare silicoflare marked this pull request as ready for review April 16, 2024 16:45
@aditeyabaral aditeyabaral merged commit 7e751c1 into HackerSpace-PESU:main Apr 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants