Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrushStoreWindow: don't allow duplicate brush adding #518

Merged
merged 1 commit into from
May 8, 2023

Conversation

dsizzle
Copy link
Collaborator

@dsizzle dsizzle commented May 6, 2023

also fixed selection of brush on deletion, as well as moving between brushes with left/right arrow keys.

fixes #502

also fixed selection of brush on deletion, as well as moving between
brushes with left/right arrow keys.
when a brush is stored, select that brush
@humdingerb
Copy link
Member

Nice touch with the selecting with cursor left/right!

Some things though:

  1. Deleting the last remaining brush will crash:
    ArtPaint-1424-debug-07-05-2023-06-25-29.report.txt
  2. Do this:
  • Store a few brushes
  • (You may need to select some other brush than the first, first)
  • Select the first brush
  • "Delete selected brush" until none (or one, beware above crash)
    --> There's an outline left from a deleted brush-square:
    frme-left
  1. "Store brush" should immediately select that just stored brush.
  2. "Reset brush" should remove any selection from the stored brushes (except if you have stored a brush with the "Reset" settings, then it should be selected).

@dsizzle dsizzle force-pushed the dont-add-dup-brush branch from 5525267 to b3b0ffb Compare May 7, 2023 19:39
@dsizzle
Copy link
Collaborator Author

dsizzle commented May 7, 2023

items 1-4 should be fixed.

"Reset brush" should remove any selection from the stored brushes (except if you have stored a brush with the "Reset" settings, then it should be selected).

I'd rather do this as part of #504 , not this change.

@humdingerb
Copy link
Member

Nicely fixed!

@humdingerb humdingerb merged commit 1dce896 into HaikuArchives:master May 8, 2023
@dsizzle dsizzle deleted the dont-add-dup-brush branch July 8, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Don't store identical brushes
2 participants