Check if busybox exists #2
Conversation
jbruechert
commented
Jul 10, 2017
•
jbruechert
commented
- Please merge only after Preconfigure SSH on device #1
jbruechert
force-pushed
the
check-busybox
branch
from
ede1190 to
b9cb07e
Compare
halium-install
Outdated
| wget https://github.com/meefik/busybox/raw/master/app/src/main/assets/intel/static/bin/busybox -O busybox/busybox | ||
| elif [ $device_architecture = armv7l ]; then | ||
| wget https://github.com/meefik/busybox/raw/master/app/src/main/assets/arm/static/bin/busybox -O busybox/busybox | ||
| elif [ $device_architecture = arm64 ]; then |
There was a problem hiding this comment.
should use an armv7l or arm64. Also apparently arm64 can also be called aarch64 but I don't have such devices to test.
halium-install
Outdated
| { | ||
| export device_architecture=$(do_shell "uname -m") | ||
| export busybox_exists=$(do_shell "if [ -d /sbin/busybox ]; then echo true; else echo false; fi") | ||
| mkdir busybox |
There was a problem hiding this comment.
move the mkdir in the else part of the next if as we don't need that directory if busybox already exists.
halium-install
Outdated
| echo 'Using already installed busybox' | ||
| else | ||
| if [ $device_architecture = x86_64 ]; then | ||
| wget https://github.com/meefik/busybox/raw/master/app/src/main/assets/intel/static/bin/busybox -O busybox/busybox |
There was a problem hiding this comment.
We could actually build our own busybox, or just use a prebuilt static one from busybox.net? I wouldn't necessarily use busybox from a random busybox app.
There was a problem hiding this comment.
They are not having armv7 builds I think ... Correct me if I'm wrong. Of course you're right, if you fing a better source, I'll use it.
There was a problem hiding this comment.
We can use the armv6l variant from https://busybox.net/downloads/binaries/1.26.2-defconfig-multiarch/ . It's working just fine on armv7
halium-install
Outdated
| wget https://github.com/meefik/busybox/raw/master/app/src/main/assets/arm/static/bin/busybox -O busybox/busybox | ||
| fi | ||
|
|
||
| adb push busybox/busybox /sbin/busybox |
There was a problem hiding this comment.
actually why do we need the busybox/ folder on the host at all? It's only a single binary...
There was a problem hiding this comment.
I think that was because I earlier downloaded more to the folder. It's now unnecessary. Thank you for pointing that out.
|
If it works, it's good :) |
jbruechert
force-pushed
the
check-busybox
branch
from
23a3ed8 to
fd76886
Compare
halium-install
Outdated
| elif [ $device_architecture = arm64 ]; then | ||
| elif [ $device_architecture = aarch64 ]; then | ||
| wget https://github.com/meefik/busybox/raw/master/app/src/main/assets/arm/static/bin/busybox | ||
| elif [ $device_architecture = armv8l ]; then |
There was a problem hiding this comment.
I think you should do if device_architecture is armv7l or aarch64 or armv8l and not three seperate branches that do exactly the same.
There was a problem hiding this comment.
I'm new to bash and didn't know it can do this. Will of course correct :)
| @@ -1,4 +1,4 @@ | |||
| #!/bin/sh | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This doesn't work with /bin/sh, so I switched to bash. If you know any reason why we should only use the sh, please report :)
There was a problem hiding this comment.
Depends what's symlinked to /bin/sh. On Arch it's bash by default but I don't know about other distros. /bin/bash ensures we get bash.
|
I tested the changes with my device, which already has busybox installed. If you still need further testing, we need a device without busybox installed in recovery. |
