Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced obsolete curl_formadd #92

Closed
wants to merge 1 commit into from

Conversation

Hritik14
Copy link

No description provided.

@HalosGhost
Copy link
Owner

This is a great start! Thanks for taking a crack at it. It looks like there are a few build errors from this:

                } else if ( state.cmd != c ) {
                            ~~~~~~~~~ ^  ~
main.c:255:51: error: implicit conversion changes signedness: 'CURLcode' to 'int' [-Werror,-Wsign-conversion]
    if ( s->llex || s->lthm || s->lfrm ) { return pb_list(s); }
                                           ~~~~~~ ^~~~~~~~~~
main.c:261:26: error: implicit conversion changes signedness: 'CURLcode' to 'int' [-Werror,-Wsign-conversion]
        case UPD: return pb_paste(s);
                  ~~~~~~ ^~~~~~~~~~~
main.c:262:26: error: implicit conversion changes signedness: 'CURLcode' to 'int' [-Werror,-Wsign-conversion]
        case SHR: return pb_shorten(s->provider, s->url, s->verb);
                  ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
main.c:264:37: error: operand of ? changes signedness: 'CURLcode' to 'int' [-Werror,-Wsign-conversion]
                                  : pb_remove(s->provider, uuid, s->verb));
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 errors generated.
make: *** [Makefile:36: bin] Error 1

I will poke around with cleaning it up in the next few days :)

@Hritik14
Copy link
Author

Those are not from the current PR. (They're in main.c and this commit doesn't touch this file).

@Hritik14
Copy link
Author

Solved the issue in #93 .
Well, actually solving it would require a lot of unnecessary overhead.

@HalosGhost HalosGhost closed this Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants