Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support log over USB serial #211

Closed
wants to merge 6 commits into from
Closed

Support log over USB serial #211

wants to merge 6 commits into from

Conversation

HaoboGu
Copy link
Owner

@HaoboGu HaoboGu commented Dec 20, 2024

No description provided.

This comment was marked as outdated.

This comment was marked as outdated.

@HaoboGu
Copy link
Owner Author

HaoboGu commented Jan 3, 2025

Known issue: the logger requires USB connection, using USB logger makes it quite complex when switching between USB and BLE.

One solution is to run the usb logger + keyboard whenever the USB is connection, but if the communication type is set to BLE, the report won't be sent to the USB reporter. Though, this needs the architecture update, which will be done later. So this PR now blocks.

Copy link

github-actions bot commented Jan 6, 2025

PR build size

  text	   data	    bss	    dec	    hex	filename
124252	    116	  41308	 165676	  2872c	rmk-nrf52840

Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +1.4% +2.76Ki  [ = ]       0    .debug_loc
  +0.1% +1.53Ki  [ = ]       0    .debug_str
  +0.1%    +948  [ = ]       0    .debug_info
  +0.4%    +499  [ = ]       0    .debug_line
  +0.3%    +432  [ = ]       0    .strtab
  +0.1%    +152  [ = ]       0    .debug_ranges
  +0.4%     +72  [ = ]       0    .debug_aranges
  +0.1%     +32  [ = ]       0    .symtab
  +0.6%      +3  [ = ]       0    .defmt
  -5.9%      -4  [ = ]       0    [Unmapped]
  -0.1%      -6  [ = ]       0    .debug_abbrev
  -0.2%     -32  [ = ]       0    .debug_frame
  -1.1%    -184  -1.1%    -184    .rodata
  -0.2%    -200  -0.2%    -200    .text
  +0.2% +5.96Ki  -0.2%    -384    TOTAL

@HaoboGu
Copy link
Owner Author

HaoboGu commented Jan 6, 2025

I'll split this PR to two, the first adds defmt feature and the second adds usb logger.

@HaoboGu HaoboGu closed this Jan 6, 2025
@HaoboGu HaoboGu mentioned this pull request Jan 6, 2025
@HaoboGu HaoboGu deleted the feat/log branch January 7, 2025 02:21
@HaoboGu HaoboGu restored the feat/log branch January 7, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant