-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a table of drop rates for every item #68
base: main
Are you sure you want to change the base?
Conversation
Zollo757347
commented
Feb 6, 2024
- Added a table of drop rates for every item, as the following image shows
- Because some crates may drop multiple loots, some items may have their calculated drop rates higher than the loot table
fixed some capitalization issues lel
Update flint_stone.md
This reverts commit 36f6661.
Vepr12 was added
Update flues.md
typo
Update vector.md
small spelling mistake 😲
OMG MAUL DESCRIPTION?!!? THATS CRAZY 😯😲🫢😮
Please format your pull request with |
It also appears that you added the same component for every article file. Try putting the table in all articles (page/layout.tsx). |
I think I can't really do that, because the table is now located at the middle of the article, under "Obtaining" section. Unlike sidebars which can be conveniently placed at the end of every article. I can also put the table at the end of the page though, but that will make it separated with "Obtaining" section, and I think that is a little bit counterintuitive. |
Fair point, I'm gonna ask @Compositr to review cuz idk how this API stuff works in NextJS |
If you want to insert the table in the middle of the article we'd need to rework how articles are rendered unfortunately. Also, the old way we used to do with |
solidjs when |
Manually adding a little component for each article isn't that bad in my opinion (that's why I chose to do it), but of course it's up to you to decide whether to keep this or not. If you don't like how this is implemented, feel free to close the PR. I will purpose the same PR if the rework is finished in the future. |
I have an idea that we can move this functionality into a separate page. We can put a link to this page in the sidebars or in the loot table page, so it won't be isolated. If that's good, then I'll work on that asap. |
I think we should just add a link to the loot tables where the item appears in the sidebar sort of how we have links to where buildings appear, etc. You can link to loot tables by passing their string ID as a |
I agree with your point, but I may prefer adding links to the obstacles that drops the item, instead of the loot tables. If I click on toilet and it leads me to the loot table, I'll be really confused. Also I'll add another link to the loot table on the obstacle sidebar so people can still get there if they want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the "Obstacles" section of the sidebar should be made more clear that it is a chance (ie, it uses a loot table). Maybe reword it to be like "Found In" or something similar.
Thanks for your help by the way, we appreciate it. Are you in the Discord server? We could coordinate easier over there if you are willing. And yes, the code for the loot tables is flawed in a few places although its such a mess I don't want to touch it lol. Its fairly accurate for smaller loot tables though. |
Yes "location" is not the perfect frase, but English is not my first language so I couldn't come up with a suitable phrase for that lol. And yes I am in the server. My username is @Zollo757347 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
, |
; |
: |