Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(verification): add multithreading to tx scripts verification #1130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Sep 4, 2024

Motivation

Improve transaction verification speed by parallelizing script verification with Python multithreading (see #1128).

Acceptance Criteria

  • Change script_eval to evaluate_scripts, which now executes multiple input scripts in parallel using Python multithreading.
  • Update transaction verifier accordingly.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Sep 4, 2024
@glevco glevco force-pushed the perf/scripts-verification branch from 269b1cd to 799ba96 Compare September 4, 2024 19:07
Copy link

github-actions bot commented Sep 4, 2024

🐰 Bencher Report

Branchperf/scripts-verification
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Lower Boundary
nanoseconds (ns)
(Limit %)
Upper Boundary
nanoseconds (ns)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
101,445,393,095.18
(-0.60%)
91,851,043,656.34
(90.54%)
112,262,386,691.08
(90.36%)
🐰 View full continuous benchmarking report in Bencher

@glevco glevco force-pushed the perf/scripts-verification branch from 799ba96 to 3653b64 Compare September 4, 2024 20:16
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.43%. Comparing base (9fddd7a) to head (b1ad670).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1130   +/-   ##
=======================================
  Coverage   84.42%   84.43%           
=======================================
  Files         317      317           
  Lines       24291    24300    +9     
  Branches     3696     3699    +3     
=======================================
+ Hits        20507    20517   +10     
+ Misses       3068     3067    -1     
  Partials      716      716           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco marked this pull request as ready for review September 4, 2024 21:41
@glevco glevco force-pushed the perf/scripts-verification branch from 3653b64 to b1ad670 Compare September 16, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant