Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(p2p): remove builder methods from P2PManager [part ?] #1159

Draft
wants to merge 1 commit into
base: refactor/p2p/renames
Choose a base branch
from

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 15, 2024

Depends on #1158

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Include here all things that this PR should solve

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 15, 2024
@glevco glevco changed the title refactor(p2p): remove builder methods from P2PManager refactor(p2p): remove builder methods from P2PManager [part 8/8] Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 73.17073% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.54%. Comparing base (ae318ec) to head (63763de).

Files with missing lines Patch % Lines
hathor/p2p/p2p_manager.py 62.50% 4 Missing and 5 partials ⚠️
hathor/builder/cli_builder.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           refactor/p2p/renames    #1159      +/-   ##
========================================================
+ Coverage                 84.50%   84.54%   +0.03%     
========================================================
  Files                       321      321              
  Lines                     24461    24459       -2     
  Branches                   3743     3740       -3     
========================================================
+ Hits                      20670    20678       +8     
+ Misses                     3071     3064       -7     
+ Partials                    720      717       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco changed the title refactor(p2p): remove builder methods from P2PManager [part 8/8] refactor(p2p): remove builder methods from P2PManager [part ?] Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant