Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2P Multiprocess Phase One [POC] #1161

Open
wants to merge 7 commits into
base: refactor/p2p/builder
Choose a base branch
from

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 16, 2024

This PR contains the POC for the P2P Multiprocess Phase One project. For more information, read the RFC.

This is a working version that is able to perform a sync while running P2P components in a single separate subprocess. Run poetry run hathor-cli run_node --testnet --data ./ to verify it. Check that the full node responds to an API call to /v1a/version in parallel to syncing, without being blocked.

There are a few limitations, being a POC:

  • I purposefully disabled syncing as a server. This node only works as a client.
  • Some configs are hardcoded.
  • There are a lot of patches and ad-hoc modifications.
  • Some APIs are broken, such as /v1a/status.
  • Linter and tests are failing.

@glevco glevco added the POC label Oct 16, 2024
@glevco glevco self-assigned this Oct 16, 2024
@glevco glevco force-pushed the glevco/p2p-mp-poc-2 branch 5 times, most recently from df2f44e to bcab73b Compare October 17, 2024 13:49
@glevco glevco force-pushed the glevco/p2p-mp-poc-2 branch from bcab73b to 5278c51 Compare October 17, 2024 19:36
@glevco glevco changed the title Glevco/p2p mp poc 2 P2P Multiprocess Phase One [POC] Oct 17, 2024
@glevco glevco mentioned this pull request Oct 17, 2024
@glevco glevco changed the base branch from master to refactor/p2p/builder October 17, 2024 22:17
@glevco glevco marked this pull request as ready for review October 18, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant