-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multiprocess): implement ConnectOnSubprocessFactory and related classes [part 10/11] #1167
Open
glevco
wants to merge
1
commit into
refactor/p2p/p2p-connection-protocol
Choose a base branch
from
feat/subprocess-protocol
base: refactor/p2p/p2p-connection-protocol
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(multiprocess): implement ConnectOnSubprocessFactory and related classes [part 10/11] #1167
glevco
wants to merge
1
commit into
refactor/p2p/p2p-connection-protocol
from
feat/subprocess-protocol
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
feat/subprocess-protocol
branch
from
October 23, 2024 21:26
9940d94
to
8127eaa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/p2p/p2p-connection-protocol #1167 +/- ##
========================================================================
- Coverage 84.73% 84.48% -0.25%
========================================================================
Files 318 321 +3
Lines 24508 24685 +177
Branches 3742 3749 +7
========================================================================
+ Hits 20766 20855 +89
- Misses 3000 3094 +94
+ Partials 742 736 -6 ☔ View full report in Codecov by Sentry. |
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
2 times, most recently
from
October 27, 2024 20:53
72d3563
to
f7bf2f2
Compare
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
from
November 5, 2024 19:23
f7bf2f2
to
c66b07d
Compare
glevco
changed the title
feat: implement subprocess protocol [part 8/8]
feat: implement subprocess protocol [part 9/8]
Nov 6, 2024
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
3 times, most recently
from
November 6, 2024 14:23
08328b2
to
b4f9b18
Compare
glevco
changed the title
feat: implement subprocess protocol [part 9/8]
feat: implement subprocess protocol [part 10/10]
Nov 6, 2024
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
from
November 6, 2024 15:33
b4f9b18
to
44e6db9
Compare
glevco
force-pushed
the
feat/subprocess-protocol
branch
2 times, most recently
from
November 6, 2024 16:54
38a8fb6
to
e9a4a90
Compare
glevco
changed the title
feat: implement subprocess protocol [part 10/10]
feat(multiprocess): implement ConnectOnSubprocessFactory and related classes [part 10/10]
Nov 6, 2024
glevco
force-pushed
the
feat/subprocess-protocol
branch
from
November 6, 2024 20:50
e9a4a90
to
aacb532
Compare
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
from
November 7, 2024 02:00
44e6db9
to
73b394a
Compare
glevco
force-pushed
the
feat/subprocess-protocol
branch
from
November 7, 2024 02:00
aacb532
to
aedf046
Compare
1 task
glevco
changed the title
feat(multiprocess): implement ConnectOnSubprocessFactory and related classes [part 10/10]
feat(multiprocess): implement ConnectOnSubprocessFactory and related classes [part 10/11]
Nov 7, 2024
glevco
force-pushed
the
refactor/p2p/p2p-connection-protocol
branch
from
November 8, 2024 15:45
73b394a
to
cb9f709
Compare
glevco
force-pushed
the
feat/subprocess-protocol
branch
from
November 8, 2024 15:46
aedf046
to
e761796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1166
Motivation
What was the motivation for the changes in this PR?
Acceptance Criteria
ConnectOnSubprocessFactory
and related classes.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged