Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multiprocess): implement ConnectOnSubprocessFactory and related classes [part 10/11] #1167

Open
wants to merge 1 commit into
base: refactor/p2p/p2p-connection-protocol
Choose a base branch
from

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Oct 23, 2024

Depends on #1166

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Implement ConnectOnSubprocessFactory and related classes.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Oct 23, 2024
@glevco glevco force-pushed the feat/subprocess-protocol branch from 9940d94 to 8127eaa Compare October 23, 2024 21:26
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 46.89266% with 94 lines in your changes missing coverage. Please review.

Project coverage is 84.48%. Comparing base (cb9f709) to head (e761796).

Files with missing lines Patch % Lines
hathor/multiprocess/subprocess_runner.py 48.35% 47 Missing ⚠️
hathor/multiprocess/connect_on_subprocess.py 45.45% 42 Missing ⚠️
hathor/multiprocess/utils.py 44.44% 5 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                            @@
##           refactor/p2p/p2p-connection-protocol    #1167      +/-   ##
========================================================================
- Coverage                                 84.73%   84.48%   -0.25%     
========================================================================
  Files                                       318      321       +3     
  Lines                                     24508    24685     +177     
  Branches                                   3742     3749       +7     
========================================================================
+ Hits                                      20766    20855      +89     
- Misses                                     3000     3094      +94     
+ Partials                                    742      736       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/p2p/p2p-connection-protocol branch 2 times, most recently from 72d3563 to f7bf2f2 Compare October 27, 2024 20:53
@glevco glevco force-pushed the refactor/p2p/p2p-connection-protocol branch from f7bf2f2 to c66b07d Compare November 5, 2024 19:23
@glevco glevco changed the title feat: implement subprocess protocol [part 8/8] feat: implement subprocess protocol [part 9/8] Nov 6, 2024
@glevco glevco force-pushed the refactor/p2p/p2p-connection-protocol branch 3 times, most recently from 08328b2 to b4f9b18 Compare November 6, 2024 14:23
@glevco glevco changed the title feat: implement subprocess protocol [part 9/8] feat: implement subprocess protocol [part 10/10] Nov 6, 2024
@glevco glevco force-pushed the refactor/p2p/p2p-connection-protocol branch from b4f9b18 to 44e6db9 Compare November 6, 2024 15:33
@glevco glevco force-pushed the feat/subprocess-protocol branch 2 times, most recently from 38a8fb6 to e9a4a90 Compare November 6, 2024 16:54
@glevco glevco changed the title feat: implement subprocess protocol [part 10/10] feat(multiprocess): implement ConnectOnSubprocessFactory and related classes [part 10/10] Nov 6, 2024
@glevco glevco marked this pull request as ready for review November 6, 2024 17:12
@glevco glevco force-pushed the feat/subprocess-protocol branch from e9a4a90 to aacb532 Compare November 6, 2024 20:50
@glevco glevco force-pushed the refactor/p2p/p2p-connection-protocol branch from 44e6db9 to 73b394a Compare November 7, 2024 02:00
@glevco glevco force-pushed the feat/subprocess-protocol branch from aacb532 to aedf046 Compare November 7, 2024 02:00
@glevco glevco changed the title feat(multiprocess): implement ConnectOnSubprocessFactory and related classes [part 10/10] feat(multiprocess): implement ConnectOnSubprocessFactory and related classes [part 10/11] Nov 7, 2024
@glevco glevco force-pushed the refactor/p2p/p2p-connection-protocol branch from 73b394a to cb9f709 Compare November 8, 2024 15:45
@glevco glevco force-pushed the feat/subprocess-protocol branch from aedf046 to e761796 Compare November 8, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant