feat(p2p): remove sync-v1 code and disable tests

[jansegre]

Motivation

We've had sync-v1 in unsafe mode for a while and bridge nodes are on their way out, also all supported releases have sync-v2 on by default, and as far as we know there's no one using sync-v1 anymore.

Acceptance Criteria

• Remove sync-v1 agent;
• Remove cli flags that enable sync-v1 directly or indirectly;
• Remove enable/disable sync-v1 methods from builder;
• Remove sync-v1 tests;
• Move sync-bridge tests to the normal classes and remove the separate classes;
• No behavior should change apart from not being able to use sync-v1;
• No tests should be removed unless it's specific to sync-v1;

Checklist

• If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

[github-actions]

Bencher Report

Branch	feat/remove-sync-v1
Testbed	ubuntu-22.04

Click to view all benchmark results

Benchmark	Latency	Benchmark Result nanoseconds (ns) (Result Δ%)	Lower Boundary minutes (m) (Limit %)	Upper Boundary minutes (m) (Limit %)
sync-v2 (up to 20000 blocks)	📈 view plot 🚷 view threshold	1.60 (-3.63%)	1.49 (93.39%)	1.83 (87.61%)

🐰 View full continuous benchmarking report in Bencher

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (692a74c) to head (745f933).

Files with missing lines	Patch %	Lines
hathor/builder/cli_builder.py	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1197      +/-   ##
==========================================
- Coverage   84.93%   83.11%   -1.82%     
==========================================
  Files         323      320       -3     
  Lines       25124    24537     -587     
  Branches     3859     3762      -97     
==========================================
- Hits        21340    20395     -945     
- Misses       3041     3394     +353     
- Partials      743      748       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[msbrogli]

These changes seem unrelated.

[jansegre]

True, these changes aren't needed.

[msbrogli]

This test seems valid for sync v2. Why did you remove it?

[jansegre]

I removed them because they were running only on sync-v1, but I should've changed it to sync-v2, with some refactoring.

[msbrogli]

This test seems to not be sync-v1 specific. Why did you remove it?

[jansegre]

This is a bad diff, the test wasn't removed. I moved the sync-v2-only tests to the main test class and removed the sync-v1-only tests, the diff didn't show this well.