tests(integration): skip first screen to allow tests to run #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroferreira1
approved these changes
Mar 8, 2024
| pytest | ||
| ``` | ||
|
|
||
| ### Launch with your Nano S/X |
There was a problem hiding this comment.
No need for this anymore?
There was a problem hiding this comment.
The integration tests were meant to run with either speculos (a ledger emulator via http api) or with your own ledger device and the ledgercomm with hid dependency was meant to be the transport layer, this was taken from the documentation at the time but this dependency was not working at all.
So I implemented the HTTP api for speculos but could not implement the hid transport, maybe this was fixed on a newer version and we can revisit this idea but for now I think we should remove it.
tuliomir
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance criteria
During tests, allow pytest to skip the first "Pending Ledger Review".