-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial client implementation #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
force-pushed
the
feat/initial-implementation
branch
from
January 22, 2024 15:41
7d4d2fb
to
6d134b8
Compare
andreabadesso
force-pushed
the
feat/initial-implementation
branch
from
January 24, 2024 14:49
2635538
to
93284f8
Compare
Co-authored-by: Pedro Ferreira <[email protected]>
pedroferreira1
approved these changes
Jan 25, 2024
alexruzenhack
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While integrating the mobile-wallet with SES, I've detected that the
unleash-proxy-client-js
library attempts to mutate the javascript prototype, which is forbidden by default by the sandboxWe could whitelist it, but since the lib has many features that we don't use, I thought it would be a better idea to create our own, with a limited subset of features that we actually use in our services and with no dependencies
Acceptance Criteria
Security Checklist