Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial client implementation #1

Merged
merged 9 commits into from
Jan 29, 2024

Conversation

andreabadesso
Copy link
Collaborator

@andreabadesso andreabadesso commented Jan 22, 2024

Motivation

While integrating the mobile-wallet with SES, I've detected that the unleash-proxy-client-js library attempts to mutate the javascript prototype, which is forbidden by default by the sandbox

We could whitelist it, but since the lib has many features that we don't use, I thought it would be a better idea to create our own, with a limited subset of features that we actually use in our services and with no dependencies

Acceptance Criteria

  • We should have a minimal version of an unleash client with only the methods we use
  • We should be able to fetch the feature toggles
  • We should be able to check wether a feature toggle is enabled or disabled for a given user
  • We should use E-TAG to reduce bandwidth (by only downloading toggles if they changed)

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Jan 22, 2024
@andreabadesso andreabadesso added the enhancement New feature or request label Jan 22, 2024
@andreabadesso andreabadesso force-pushed the feat/initial-implementation branch from 7d4d2fb to 6d134b8 Compare January 22, 2024 15:41
@andreabadesso andreabadesso force-pushed the feat/initial-implementation branch from 2635538 to 93284f8 Compare January 24, 2024 14:49
.gitignore Outdated Show resolved Hide resolved
src/utils/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
@andreabadesso andreabadesso merged commit ee6af37 into master Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants