feat: nano contract wallet integration #580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroferreira1
force-pushed
the
feat/nano-wallet-integration
branch
from
3d76e3e to
5178399
Compare
|
@pedroferreira1, I'm landing the @r4mmer suggestion commented in my PR here just to give it the right context. We can also create an issue for it.
|
pedroferreira1
force-pushed
the
feat/nano-wallet-integration
branch
from
e519061 to
8bbfa3b
Compare
pedroferreira1
force-pushed
the
feat/nano-wallet-integration
branch
from
50dfe66 to
70c866c
Compare
pedroferreira1
force-pushed
the
feat/nano-wallet-integration
branch
from
db44fe9 to
e840b86
Compare
feat: add nano APIs to get state and history feat: add nano contract class and serialization class feat: add methods to fully integrate bet blueprint with the wallet class tests: integration tests should run only after the hathor core docker image supports nano tests: add comments about skipped integration test docs: add docstring to utils methods docs: add docstring to nc builder methods refactor: reuse code through nano contract methods and create error class to throw specific errors docs: improve new methods documentation refactor: create a class for the bet blueprint with each method implementation and a generic method for the wallet class feat: add new nano API fields for state and history feat: create nano contract builder to improve integration fix: should check args types only if there are args tests: update integration tests for bet with new APIs parameters and NC builder feat: add support for custom token in actions chore: remove unused import fix: call getHDPrivateKeyFromAddress with options as second param (#592) This function extracts the pin from options or get the default value from the wallet. The current implementation causes an error in the wallet-mobile because the wallet doesn't have a default pin. feat: add get blueprint information api feat: add nano contract to the tx version feat: add nano contract parser and deserializer refactor: remove argument types in the builder and improve actions typing feat: add error handling to nano contract tx parse refactor: getOracleInputData now receives oracle data as buffer refactor: execute nc method now checkes the argument types of each parameter validating with the full node blueprint API tests: adapt integration tests for new nano method parameters feat: add support for parsing str and signed data fix: fix bytes handling for signed fields docs: add docstring to nano utils methods and add its methods to the lib.ts file tests: refactor in test to use new method name and nano serializer in the result
pedroferreira1
force-pushed
the
feat/nano-wallet-integration
branch
from
e840b86 to
54b250c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Security Checklist