Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ci issues #586

Closed
wants to merge 3 commits into from
Closed

chore: fix ci issues #586

wants to merge 3 commits into from

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Oct 30, 2023

Acceptance Criteria

  • Investigate CI issues on dev branch

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer self-assigned this Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29ca737) 64.86% compared to head (cc7cc3c) 78.28%.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #586       +/-   ##
===========================================
+ Coverage   64.86%   78.28%   +13.41%     
===========================================
  Files          67       67               
  Lines        5254     5254               
  Branches     1108     1108               
===========================================
+ Hits         3408     4113      +705     
+ Misses       1766     1126      -640     
+ Partials       80       15       -65     
Files Coverage Δ
src/new/wallet.js 95.61% <ø> (+54.80%) ⬆️

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r4mmer r4mmer changed the title chore: minor changes to trigger ci chore: fix ci issues Oct 30, 2023
@r4mmer
Copy link
Member Author

r4mmer commented Nov 3, 2023

Closing in favor of #585

@r4mmer r4mmer closed this Nov 3, 2023
@r4mmer r4mmer deleted the poc/fix-ci-issues branch November 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant