refactor: increase network size to 32 characters in the database #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We store in the wallet-service the data from the fullnode's
/v1a/version
API in aversion_data
table.This is done lazily when wallets request the
/version
API, it detects that the data it has in the database expired and requests again.We noticed that the
network
field was being stored truncated, e.g.:testnet-
nano-tes
Upon investigation, we found out that the
version_data
table had too few characters in its definition for thenetwork
column:Which was causing it to truncate text when inserting.
Acceptance Criteria
network
column.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged