Fix plus keybind on Mac

[NeeEoo]

This allows pressing + on Mac. Might only work for Swedish Mac keyboards since i don't have a english keyboard

[Geokureli]

Looks like swedish keyboards have a different layout, FlxKeys do not map to characters, they map to keyboard button locations which are labelled based on their location in the english keyboard layout, your PLUS key seems to be ` or '

Swedish:

English:

[NeeEoo]

I don't see why it would be closed, the ascii code 43 means +

And i got 0_43 when i traced the values i got directly

[Geokureli]

FlxKeys do not map to characters, they map to keyboard button locations which are labelled based on their location in the english keyboard layout

Also, my + key works fine on mac targets as well as all other targets, I suspect the issue is that your keyboard moves keys around, meaning this change would break non-swedish keyboard layouts

[NeeEoo]

What mac do you have?

[Geokureli]

US English Layout

https://keyshorts.com/blogs/blog/37615873-how-to-identify-macbook-keyboard-localization

[NeeEoo]

I mean mac model, because it worked when i had a 2017 model, but not my 2023 model

[Geokureli]

I do have a 2017, but then would this change break plus on 2017s

[NeeEoo]

It wouldnt break, pressing plus there would return a different keycode, which would return the key 61_187 which has no nativeCorrection mapping which then makes it point to FlxKey.PLUS (187) due to the code below

var code = _nativeCorrection.get(e.charCode + "_" + e.keyCode);
return (code == null) ? e.keyCode : code;

this pr is only if the key returns 0_43

[Geokureli]

aight let's test this, sorry for the misunderstanding

Edit: if I were to find someone with a 2023 mac with an English keyboard layout, how would I have them test this?

Edit2: Can you try this out using the virtual keyboard set to the English layout:
https://support.apple.com/guide/mac-help/use-the-keyboard-viewer-on-mac-mchlp1015/mac
https://support.apple.com/guide/mac-help/write-in-another-language-on-mac-mchlp1406/14.0/mac/14.0

[NeeEoo]

I just placed a trace here to get the value

trace(e.charCode + "_" + e.keyCode);

And it does work with setting the layout to US and pressing the ` key it returns the code 61_187

[Geokureli]

And it does work with setting the layout to US and pressing the key it returns the code61_187`

what if you press +?

[NeeEoo]

When i said i pressed the ` button, that is the key which is equal to + when im on us keyboard layout

[Geokureli]

When i said i pressed the ` button, that is the key which is equal to + when im on us keyboard layout

It is not, refer back to the pictures I sent, plus is typically on the = key. Also please verify that you can change the volume with the + (=) key in a flixel game using this branch

[NeeEoo]

Pressing the + (=) key on us keyboard layout still works with this branch

[Geokureli]

thanks!