Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch processing order in Fonduer tutorial #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YasushiMiyata
Copy link

Changes to be committed:
modified: hardware/max_storage_temp_tutorial.ipynb
modified: hardware_image/transistor_image_tutorial.ipynb
modified: wiki/president_place_of_birth_tutorial.ipynb

(1) Switching the Multimodal Featurization process to ahead of training the Discriminative Model process.
(2) Fixing the tutorial sentence along with the outline in Fonduer paper.
(1) is because Fonduer’s Multimodal Featurization process affects not the Generative Model but the Discriminative Model.
Previous version is a little bit confusing to understand the difference between Discriminative Model and Generative Model.
In regards of (2), I guess that previous version intends collecting static process before the iterative process.
However, to understand Generative Model , Discriminative Model and Fonduer’s Multimodal Featurization,
it might be a better way to switch tutorial order and fix the tutorial sentence along with the switching.

Changes to be committed:
      modified:   hardware/max_storage_temp_tutorial.ipynb
      modified:   hardware_image/transistor_image_tutorial.ipynb
      modified:   wiki/president_place_of_birth_tutorial.ipynb

(1) Switching the Multimodal Featurization process to ahead of training the Discriminative Model process.
(2) Fixing the tutorial sentence along with the outline in Fonduer paper.
 (1) is because Fonduer’s Multimodal Featurization process affects not the Generative Model but the Discriminative Model.
Previous version is a little bit confusing to understand the difference between Discriminative Model and Generative Model.
 In regards of (2), I guess that previous version intends collecting static process before the iterative process.
However, to understand Generative Model , Discriminative Model and Fonduer’s Multimodal Featurization,
it might be a better way to switch tutorial order and fix the tutorial sentence along with the switching.
@YasushiMiyata
Copy link
Author

Hello, thank you for your "fonduer-tutorial" maintenance. I utilize Fonduer for my work. This is a proposal draft for better understanding of fonduer's Generative Model , Discriminative Model and Multimodal Featurization.

@senwu
Copy link
Contributor

senwu commented Jul 17, 2020

Thanks for your PR! Please let us know when it's ready.

@YasushiMiyata
Copy link
Author

Thank you for commenting me. I will ready within a day or a few days after re-checking.

Changes to be committed:
      modified:   hardware/max_storage_temp_tutorial.ipynb
      modified:   wiki/president_place_of_birth_tutorial.ipynb
@YasushiMiyata YasushiMiyata marked this pull request as ready for review July 17, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants