Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let NodeUnpublishVolume pass when it cannot find volume #73

Merged
merged 1 commit into from
Apr 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/lustre-driver/service/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ package service

import (
"os"
"strings"

log "github.com/sirupsen/logrus"
"golang.org/x/net/context"
Expand Down Expand Up @@ -121,7 +122,9 @@ func (s *service) NodeUnpublishVolume(

mounter := mount.New("")
notMountPoint, err := mount.IsNotMountPoint(mounter, req.GetTargetPath())
if err != nil {
if err != nil && strings.Contains(err.Error(), "no such") {
// consider it unmounted
} else if err != nil {
return nil, status.Errorf(codes.Internal, "NodeUnpublishVolume - Mount point check Failed: Error %v", err)
} else if !notMountPoint {
err := mounter.Unmount(req.GetTargetPath())
Expand Down
Loading