Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send SDK message to HubSpot if usesCallingWindow=false #266

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Send SDK message to HubSpot if usesCallingWindow=false #266

merged 4 commits into from
Jan 27, 2025

Conversation

esme
Copy link
Contributor

@esme esme commented Jan 24, 2025 •
edited
Loading

Description

Jira Ticket: CALL-xxxx

This updates the demo react widget for usesCallingWindow=false.

If usesCallingWindow is false, we show an open calling window link. The window will allow us to send SDK events to all open tabs.

Screenshot 2025-01-24 at 11 25 41 AM

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix? yes
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-266/

Built to branch gh-pages at 2025-01-24 22:32 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@esme esme marked this pull request as ready for review January 24, 2025 19:32
@esme esme requested a review from a team as a code owner January 24, 2025 19:32
@esme
Copy link
Contributor Author

esme commented Jan 24, 2025

@alonso-cadenas
image

@esme esme merged commit 0d82acb into master Jan 27, 2025
1 check passed
@esme esme deleted the uses-calling-window-react-2 branch January 27, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonso-cadenas alonso-cadenas alonso-cadenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esme @alonso-cadenas