Skip to content

Commit

Permalink
updating copy
Browse files Browse the repository at this point in the history
  • Loading branch information
brandenrodgers committed Dec 14, 2023
1 parent 33daffe commit 1b74455
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 5 deletions.
7 changes: 4 additions & 3 deletions packages/cli/lang/en.lyaml
Original file line number Diff line number Diff line change
Expand Up @@ -952,9 +952,10 @@ en:
feedbackHeader: "We'd love to hear your feedback!"
feedbackMessage: "How are you liking the new projects and developer tools? \n > Run `{{#yellow}}hs feedback{{/yellow}}` to let us know what you think!\n"
showPlatformVersionWarning:
noPlatformVersion: "No platformVersion found in hsproject.json. Falling back to version \"{{ defaultVersion }}\"."
noPlatformVersionAlt: "No platformVersion found in hsproject.json. Falling back to default version."
deprecatedVersion: "Projects with platformVersion 2023.1 or unspecified versions will no longer be supported on"
docsLink: "Projects platform versioning (BETA)"
noPlatformVersion: "No platformVersion found in hsproject.json. Falling back to version \"{{ defaultVersion }}\". Starting Mar 31, 2024, projects without a specified version will no longer be supported. To update your project to the latest version, see {{ docsLink }}."
noPlatformVersionAlt: "No platformVersion found in hsproject.json. Falling back to default version. Starting Mar 31, 2024, projects without a specified version will no longer be supported. To update your project to the latest version, see {{ docsLink }}."
deprecatedVersion: "Starting Mar 31, 2024, projects with platformVersion 2023.1 or unspecified versions will no longer be supported. It's recommended that you update your project to the latest version. For more info, see {{ docsLink }}."
ui:
betaTag: "{{#bold}}[BETA]{{/bold}}"
betaWarning:
Expand Down
13 changes: 11 additions & 2 deletions packages/cli/lib/projects.js
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,10 @@ const createProjectComponent = async (

const showPlatformVersionWarning = async (accountId, projectConfig) => {
const platformVersion = projectConfig.platformVersion;
const docsLink = uiLink(
i18n(`${i18nKey}.showPlatformVersionWarning.docsLink`),
'https://developers.hubspot.com/docs/platform/developer-projects-setup'
);

if (!platformVersion) {
try {
Expand All @@ -878,21 +882,26 @@ const showPlatformVersionWarning = async (accountId, projectConfig) => {
logger.warn(
i18n(`${i18nKey}.showPlatformVersionWarning.noPlatformVersion`, {
defaultVersion,
docsLink,
})
);
logger.log('');
} catch (e) {
logger.log('');
logger.warn(
i18n(`${i18nKey}.showPlatformVersionWarning.noPlatformVersionAlt`)
i18n(`${i18nKey}.showPlatformVersionWarning.noPlatformVersionAlt`, {
docsLink,
})
);
logger.log('');
logger.debug(e.error);
}
} else if (platformVersion === '2023.1') {
logger.log('');
logger.warn(
i18n(`${i18nKey}.showPlatformVersionWarning.deprecatedVersion`)
i18n(`${i18nKey}.showPlatformVersionWarning.deprecatedVersion`, {
docsLink,
})
);
logger.log('');
}
Expand Down

0 comments on commit 1b74455

Please sign in to comment.