Remove verbose command, fix npm version, move file writing to up front

packages/cli/commands/doctor.js

@@ -8,32 +8,25 @@ const { EXIT_CODES } = require('../lib/enums/exitCodes');
 exports.command = 'doctor';
 exports.describe = 'The doctor is in';
 
-exports.handler = async ({ file, verbose }) => {
+exports.handler = async ({ file }) => {
   const doctor = new Doctor();
 
   try {
     trackCommandUsage('doctor', null, doctor.accountId);
   } catch (e) {
     logger.debug(e);
   }
-
-  const diagnosis = await doctor.diagnose();
-
-  const stringifiedOutput = JSON.stringify(diagnosis, null, 4);
-
-  if (verbose) {
-    console.log(stringifiedOutput);
-  }
-
   if (file) {
     try {
-      fs.writeFileSync(file, stringifiedOutput);
-      logger.success(`Output written to ${file}`);
+      fs.writeFileSync(file, JSON.stringify(doctor.generateOutput(), null, 4));
+      logger.info(`Output written to ${file}`);
     } catch (e) {
       logger.error(`Unable to write output to ${file}, ${e.message}`);
       process.exit(EXIT_CODES.ERROR);
     }
   }
+
+  await doctor.diagnose();
 };
 
 exports.builder = yargs =>
@@ -42,8 +35,4 @@ exports.builder = yargs =>
       describe: 'Where to write the output',
       type: 'string',
     },
-    verbose: {
-      describe: 'Chatty?',
-      type: 'boolean',
-    },
   });

packages/cli/lib/doctor.js

@@ -54,8 +54,6 @@ class Doctor {
       ...this.checkIfNpmInstallRequired(),
       ...this.validateProjectJsonFiles(),
     ]);
-
-    return this.generateOutput();
   }
 
   async checkIfNodeIsInstalled() {
@@ -152,7 +150,8 @@ class Doctor {
   async getNpmVersion() {
     const exec = util.promisify(execAsync);
     try {
-      return (await exec('npm --version')).toString().trim();
+      const { stdout } = await exec('npm --version');
+      return stdout.toString().trim();
     } catch (e) {
       logger.debug(e);
       return null;