chore: Update linter so we can leverage modern JS features #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
approved these changes
Sep 11, 2024
kemmerle
reviewed
Sep 11, 2024
| @@ -6,7 +6,7 @@ | |||
| "private": true, | |||
| "devDependencies": { | |||
| "depcheck": "1.3.1", | |||
| "eslint": "7.32.0", | |||
| "eslint": "^8.56.0", | |||
There was a problem hiding this comment.
OOC, why this version of eslint? Is it just the latest version from 2022?
There was a problem hiding this comment.
Good question. V7 didn't seem to have support for 2022, and V9 introduced some fairly large changes to the config files. It dropped support for the .eslintignore, renamed eslintrc.js to eslint.config.js, and significantly changed the format of eslint.config.js.
Also, LDL is using V8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Update the linter to use
es2022since node 18 fully supportses2022https://node.green/#ES2022