Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expand lib test coverage (hasFlags, hasFeatures, developerTestAccounts) #1348

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

brandenrodgers
Copy link
Contributor

Description and Context

Adding tests for:

  • lib/hasFlags
  • lib/hasFeatures
  • lib/developerTestAccounts

Screenshots

TODO

Who to Notify

joe-yeager
joe-yeager previously approved these changes Jan 21, 2025
Copy link
Contributor

@joe-yeager joe-yeager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some leftover console.logs statements

lib/__tests__/developerTestAccounts.test.ts Outdated Show resolved Hide resolved
@joe-yeager joe-yeager self-requested a review January 22, 2025 17:33
@brandenrodgers brandenrodgers merged commit f936c67 into main Jan 22, 2025
1 check passed
@brandenrodgers brandenrodgers deleted the br/p1-lib-util-tests branch January 22, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants