chore: unit tests for polling #1353
Conversation
brandenrodgers
requested review from
camden11,
kemmerle and
joe-yeager
as code owners
| accountId: number, | ||
| taskId: number | string | ||
| ) => HubSpotPromise<T>; | ||
| type PollingCallback<T extends GenericPollingResponse> = |
There was a problem hiding this comment.
I changed the signature of the callback so we could simplify the arguments in poll. This makes the polling function more generic so it can be more easily leveraged in other places.
| FAILURE: 'FAILURE', | ||
| } as const; | ||
|
|
||
| const DEFAULT_POLLING_STATUS_LOOKUP = { |
There was a problem hiding this comment.
This lookup will enable this polling func to be used for other apis, even if their status enums are slightly different from the default ones here. The only requirement in the polling util now is that the callback response needs to include a status field.
| import { POLLING_DELAY, POLLING_STATUS } from './constants'; | ||
| import { DEFAULT_POLLING_DELAY } from './constants'; | ||
|
|
||
| export const DEFAULT_POLLING_STATES = { |
There was a problem hiding this comment.
I moved this here because it's only relevant to this file
| const pollPromise = poll(mockCallback); | ||
|
|
||
| // Fast-forward through two polling intervals | ||
| jest.advanceTimersByTime(DEFAULT_POLLING_DELAY * 2); |
There was a problem hiding this comment.
Cursor came up with the idea to use advanceTimersByTime, but it's a cool way to test utils that leverage setTimeout. This gives us control over each execution of the setTimeout in poll(). So we can iterate over the mock responses one at a time.
Description and Context
Adding tests for lib/polling. I also made some changes to make the polling function more generic and easier to test. I'll add more context inline.
Screenshots
TODO
Who to Notify