Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap cli lib deps 2 #950

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Swap cli lib deps 2 #950

merged 4 commits into from
Nov 9, 2023

Conversation

camden11
Copy link
Contributor

@camden11 camden11 commented Nov 3, 2023 •
edited
Loading

Description and Context

This switches to using hubspot-local-dev-lib for the following dependancies:

  • @hubspot/cli-lib/lib/validate
  • @hubspot/cli-lib/lib/environment
  • @hubspot/cli-lib/lib/ignoreRules

Also bumps the deps on local-dev-lib and cli-lib to the latest versions

Who to Notify

@brandenrodgers

@camden11 camden11 marked this pull request as ready for review November 7, 2023 20:30
brandenrodgers
brandenrodgers approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@brandenrodgers brandenrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! The syntax of getValidEnv is different in local-dev-lib than it is in cli-lib, but it looks like it doesn't matter because nothing in here uses the second arg anyways.

@camden11 camden11 merged commit 57576a2 into master Nov 9, 2023
1 check passed
@camden11 camden11 deleted the swap-cli-lib-deps-2 branch November 9, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandenrodgers brandenrodgers brandenrodgers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camden11 @brandenrodgers