Use local-dev-lib for archive and gitignore #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/cli/commands/init.js
Outdated
| @@ -117,7 +119,7 @@ exports.handler = async options => { | |||
| ); | |||
| const configPath = getConfigPath(); | |||
|
|
|||
| checkAndUpdateGitignore(configPath); | |||
| checkAndAddConfigToGitignore(configPath); | |||
There was a problem hiding this comment.
It looks like in cli-lib the checkAndUpdateGitignore function was set up to purposely fail silently in the catch block. Maybe we want to add a try/catch here so we can keep the silent fail behavior?
|
|
||
| const i18nKey = 'cli.commands.project.subcommands.download'; | ||
| const { EXIT_CODES } = require('../../lib/enums/exitCodes'); | ||
|
|
||
| const archiveLogCallbacks = buildLogCallbacks({ | ||
| init: 'Extracting project source...', |
There was a problem hiding this comment.
Should this be added to the translations file?
|
Fixed both of these! |
brandenrodgers
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This swaps
@hubspot/cli-lib/lib/gitand@hubspot/cli-lib/archivefor@hubspot/local-dev-lib/gitignoreand@hubspot/local-dev-lib/archiverespectively. Also adds a util for using logcallbacks, and updatesdebugErrorAndContextto include information about thecauseof errorsWho to Notify
@brandenrodgers