Update some more of the cms imports to use local-dev-lib #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review now, although it's dependent on the latest changes over in local-dev-lib. We will need to cut a new patch release of LDL before merging/releasing this. |
camden11
approved these changes
Jan 19, 2024
brandenrodgers
commented
Feb 1, 2024
|
|
||
| // Update the log level in local-dev-lib's instance of the logger | ||
| // This will evenutally replace cli-lib's version of it | ||
| setLocalDevLibLogLevel(LOG_LEVEL.DEBUG); |
There was a problem hiding this comment.
I realized that certain log statements in local-dev-lib were not working correctly. It was because the default log level is NONE, and we were only setting the log level to LOG for the cli-lib instance of the logger.
camden11
approved these changes
Feb 1, 2024
|
Good catch with the log level stuff. Also this whole PR is a pretty solid case against log callbacks. Looks like there are some tests failing but otherwise looks good |
|
I updated everything that uses logCallbacks in response to: HubSpot/hubspot-local-dev-lib#95 |
camden11
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Updating imports for
cli-lib/functions,cli-lib/modules, andcli-lib/templatesto pull from their new local-dev-lib counterparts.Screenshots
TODO
Who to Notify