Default account names for hs init and hs auth #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/cli/commands/auth.js
Outdated
| @@ -98,7 +104,11 @@ exports.handler = async options => { | |||
| case PERSONAL_ACCESS_KEY_AUTH_METHOD.value: | |||
| configData = await personalAccessKeyPrompt({ env, account }); | |||
|
|
|||
| updatedConfig = await updateConfigWithPersonalAccessKey( | |||
| token = await getAccessToken(configData.personalAccessKey, env); | |||
There was a problem hiding this comment.
Does this need a try/catch like it had in the lib?
|
IIRC there might be some sandboxes commands that make use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Now that the
localDevAuthendpoints returnshubName, we can use that name as a default when setting up a new account on the CLI viahs initorhs auth. This slightly refactors both of those commands to add support for this.cc @adamawang This also fixes the lang errors with sandbox gate syncing
Screenshots
TODO
Who to Notify
@brandenrodgers