API errors expects new error format #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,108 @@ | |||
| import { | |||
There was a problem hiding this comment.
Thanks for adding these! It's a huge help 🙏
adamawang
commented
Feb 2, 2024
| describe('isMissingScopeError()', () => { | ||
| it('returns true for missing scope errors', () => { | ||
| const error1 = newAxiosError({ | ||
| status: 403, | ||
| response: { data: { category: 'MISSING_SCOPES' } }, | ||
| response: { status: 403, data: { category: 'MISSING_SCOPES' } }, |
There was a problem hiding this comment.
I saw the AxiosError type definition does include a status property, but I wasn't able to log any statuses directly from error when testing with actual API calls... I had to go one level deeper into the response (AxiosResponse type) to pull status, hence the changes to the tests here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
All the updates here were to update the error utilities to accept the new AxiosError error formats. The APIs were upgraded during a migration in November 2023, but the error handlers were old versions expecting a different format.
I did a full search across all 3 repos (cli-lib, LDL, CLI) and I don't believe any of the exports from
apiErrors.tsare being used yet, so this should be a fairly low risk PR.Related CLI PR: HubSpot/hubspot-cli#990
Screenshots
n/a
TODO
n/a
Who to Notify
@shannon-lichtenwalter