-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General test harness improvements #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few suggestions, but overall looks okay to me!
treon==0.1.3 runs notebooks in their directory so we can discard the workarounds that we have
ec71ede
to
ed04b42
Compare
249f7da
to
60de67f
Compare
Travis is failing for Python 3.8 only, due to some packages that are not imported. It looks like there is a problem with Python 3.8 and the llvmlite package. It fails to build, which causes other packages to not be installed and therefore causes import errors. (I'm also experiencing some similar errors in my build for #87.) Relevant sections from your Travis output:
|
2183774
to
beab332
Compare
It looks like llvmlite does not support Python 3.8 (numba/llvmlite#527). Why this didn't break testing, I can't say. The issue indicates that Python 3.8 support should be readily available over pip some time after New Year's. I think for now it makes sense to drop 3.8 testing and add it after curtailment. |
eaf3a0b
to
a271381
Compare
agreed, let's drop 3.8 for now and add it back in once everything in the build chain works with 3.8 |
17e2b22
to
774a14c
Compare
This means that we can throw away the workaround we had in `.travis.yml`. Not a super big change, but it feels nice.
Matplotlib is choking on something that it didn't choke on before. Maybe this will fix it.
See #88. Waiting on Python 3.8 support in numba/llvmlite.
774a14c
to
4f17bf3
Compare
🎉 |
☝️ still have a bit of red text during the pip install phase - but let's clear that up in a later pull request. LGTM 💪 |
A bunch of miscellaneous improvements to the test harness.
This PR closes #89.
As a consequence of some of the changes above, build time has been cut from some 30 minutes to just over three minutes. Neat!