DX improvements #62
Merged
DX improvements #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matt-bernstein
commented
Mar 8, 2024
matt-bernstein
commented
- switch from pdm to poetry
- improve docker setup, let docker run on local codebase instead of from github
- standardize server API structure for easier communication to LS
|
@niklub LMK if you have concerns with any of these changes and I can break them out into separate PRs, if not, can you merge it? |
matt-bernstein
force-pushed
the
dev/matt-fixes
branch
from
9780094 to
07b352f
Compare
niklub
requested changes
Mar 12, 2024
|
Overall, LGTM with a few minor changes |
|
thanks for the review, made the changes you suggested and will merge when this github outage is over and the PR updates :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.