Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DIA-940: Read Adala predictions back in once they are completed #5567

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

matt-bernstein
Copy link
Contributor

@matt-bernstein matt-bernstein commented Mar 12, 2024

Small db changes to support LSE PR, see that one for details.

Related PRs:

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 3963843
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/65f8535205ef570008e0c3f6
😎 Deploy Preview https://deploy-preview-5567--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 3963843
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/65f85352c4f8690008a231a3
😎 Deploy Preview https://deploy-preview-5567--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matt-bernstein matt-bernstein marked this pull request as draft March 12, 2024 19:18
@matt-bernstein matt-bernstein changed the title [Draft] Feat: DIA-940: Read Adala predictions back in once they are completed Feat: DIA-940: Read Adala predictions back in once they are completed Mar 12, 2024
@matt-bernstein
Copy link
Contributor Author

will add the Prediction modelrun field in a sec, have to deconflict with the other updates to develop today

@matt-bernstein matt-bernstein force-pushed the fb-dia-940/read-adala-predictions branch from a8b7ffd to 5af08c3 Compare March 12, 2024 20:18
@matt-bernstein matt-bernstein changed the title Feat: DIA-940: Read Adala predictions back in once they are completed feat: DIA-940: Read Adala predictions back in once they are completed Mar 12, 2024
matt-bernstein

This comment was marked as duplicate.

@matt-bernstein matt-bernstein force-pushed the fb-dia-940/read-adala-predictions branch from 553f7be to 94778ed Compare March 13, 2024 14:43
@matt-bernstein
Copy link
Contributor Author

rebased on DIA-939 and deconflicted duplicate changes, but this is still NOT mergeable, because it includes conflicting changes to Prediction model that were reverted in d1021d6 on develop - need to figure out what the status of those changes is

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.84%. Comparing base (9ee5db9) to head (3963843).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5567      +/-   ##
===========================================
+ Coverage    75.76%   75.84%   +0.08%     
===========================================
  Files          157      157              
  Lines        13146    13150       +4     
===========================================
+ Hits          9960     9974      +14     
+ Misses        3186     3176      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-bernstein matt-bernstein force-pushed the fb-dia-940/read-adala-predictions branch from 94778ed to 9f0fd2c Compare March 13, 2024 18:14
@matt-bernstein matt-bernstein force-pushed the fb-dia-940/read-adala-predictions branch from 9f0fd2c to 3963843 Compare March 18, 2024 14:44
@matt-bernstein matt-bernstein marked this pull request as ready for review March 18, 2024 14:47
@matt-bernstein matt-bernstein merged commit 174a04c into develop Mar 18, 2024
57 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants