Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #8

Merged
merged 13 commits into from
Dec 10, 2024
Merged

Refactor #8

merged 13 commits into from
Dec 10, 2024

Conversation

haakoek
Copy link
Collaborator

@haakoek haakoek commented Dec 10, 2024

  • Fix sign for boundary elements of D1 in Legendre-Lobatto basis. The expression for D1[0,0] and D1[N,N] given by Eq.(F.55) in Ref.[1] has the wrong sign as opposed to the expression (3) for d_ij in Ref.[2].
  • Add tests for differentiation matrices, numerical integration of polynomials and $f(x) = x^k exp(-ax^2)$, and eigenvalues and eigenfunctions for the 1D particle in box and harmonics oscillator using the Gauss-Legendre-Lobatto grid.
  • Remove unused scripts and modules from the spherical_coordinates directory.
  • Remove unused functions in spherical_coordintates/utils.py. In particular, remove functions that used numba. Thus, there should no longer be necessary to have numba installed for the package to work.
  • Import gauss_legendre_lobatto from pseudospectral_grids in all examples.

[1]: Boyd, John P. Chebyshev and Fourier spectral methods. Courier Corporation, 2001.
[2]: https://doc.nektar.info/tutorials/latest/fundamentals/differentiation/fundamentals-differentiationch2.html

@haakoek haakoek merged commit 943071b into main Dec 10, 2024
2 checks passed
@haakoek haakoek deleted the refactor branch December 11, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant